-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of parse_subarray_map_step and test #69
Conversation
@astrobc1 reading https://oirlab.github.io/iris-pipeline/parse_subarray_map/index.html it seems like the purpose of the step is to create those fields. we definitely had subarray map at: liger_iris_pipeline/iris_pipeline/datamodels/schemas/iris_image.schema.yaml Lines 17 to 21 in bce4533
my bad, I lost that field in the refactoring, it defintely was there, see liger_iris_pipeline/iris_pipeline/datamodels/schemas/tmt_core.schema.yaml Lines 1979 to 1996 in bce4533
I now restored it. |
I think we were able to have multiple subarrays, but I don't remember exactly how it worked, let me look into that and report back here. |
@astrobc1 actually no, each file only has 1 subarray, so I think subarray map is defined in the "Full frame" to keep track of the subarrays, but the subarrays are not actually in that file but in separate fits files. |
example of subarray is at https://figshare.com/articles/dataset/TMT-IRIS_raw_science_frame_subarray/11953512 |
@astrobc1 there are some examples and explanation around page 60 of the design document |
@zonca Could you take a look at my progress on
ParseSubarrayMapStep
? It fails in this loop:liger_iris_pipeline/liger_iris_pipeline/parse_subarray_map/parse_subarray_map_step.py
Lines 49 to 50 in d1cd12c
result
is aLigerIrisImage
andresult.meta
has no attributesubarr_map
to store alist
ofxstart, ystart, xsize
, etc. The schemas are consistent with this. There isresult.meta.subarray
, but it is designed for one subarray;result.meta.subarray = each
works for a singledict
.Can a single
LigerIrisImage
contain multiple subarrays at this stage? Eventually we should consider that subarrays are only relevant for IRIS, but maybe not just yet.